fix(launchServer): return precise wsAddress #31026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"27063 passed, 609 skipped Merge workflow run. |
dgozman
reviewed
May 28, 2024
| resolve(`${address}${path}`); | ||
| return; | ||
| } | ||
| const resolvedHost = address.family === 'IPv4' ? address.address : `[${address.address}]`; |
There was a problem hiding this comment.
- Shouldn't this be
hostnamewhen it is defined? - I am afraid this could accidentally break someone expecting
localhostin the address and getting127.0.0.1or[::1]instead. Should we wait for a bug report?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #30999 following a similar pattern like in #30853.