This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Move more code to pydevd #1519
Merged
Move more code to pydevd #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioz
approved these changes
Jun 13, 2019
| @@ -885,7 +885,7 @@ def _evaluate_response(py_db, request, result, error_message=''): | |||
| variables_response = pydevd_base_schema.build_response(request, kwargs={'body':body}) | |||
| py_db.writer.add_command(NetCommand(CMD_RETURN, 0, variables_response, is_json=True)) | |||
| else: | |||
| body = pydevd_schema.EvaluateResponseBody(result='', variablesReference=0) | |||
| body = pydevd_schema.EvaluateResponseBody(result=result, variablesReference=0) | |||
There was a problem hiding this comment.
Actually, reviewing this now it seems that result can be any Python object if py_db.suspended_frames_manager.get_frame_tracker(thread_id) returns None, in internal_evaluate_expression_json, which is unlikely but not impossible on a racing condition.
So, in that condition, when calling _evaluate_response, the result should be result='' and not the actual result from the evaluation.
i.e.: the line that calls this method after if frame_tracker is None: should be:
_evaluate_response(py_db, request, result='', error_message='Thread id: %s is not current thread id.' % (thread_id,))
int19h
approved these changes
Jun 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.