Ensure port is set on enable_attach #1537

karthiknadig · 2019-06-24T20:23:46Z

Users should be able to call enable attach with port 0 and have a way to get the port address.

> import ptvsd
> ptvsd.enable_attach(('localhost', 0))
('loclahost', 58940)

src/ptvsd/attach_server.py

karthiknadig added 2 commits June 24, 2019 13:18

Ensure port is set to server listening port.

c1923d2

Remove debug code

f4175ac

karthiknadig requested a review from int19h June 24, 2019 20:23

int19h reviewed Jun 24, 2019

View reviewed changes

src/ptvsd/attach_server.py Show resolved Hide resolved

int19h approved these changes Jun 24, 2019

View reviewed changes

Address comments.

17ab422

karthiknadig force-pushed the ensureport branch from 3bf8910 to 17ab422 Compare June 24, 2019 23:02

karthiknadig merged commit 1b5f6ef into microsoft:master Jun 24, 2019

karthiknadig deleted the ensureport branch July 1, 2019 17:45

Provide feedback