This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Make tuples with different arguments different types #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -415,7 +415,7 @@ class TupleProtocol : IterableProtocol { | |||
| return AnalysisSet.UnionAll(constants.Select(GetItem)); | |||
| } | |||
|
|
|||
| public override string Name => "tuple"; | |||
| public override string Name => "tuple[{0}]".FormatInvariant(string.Join(", ", _values.Select(v => v.GetShortDescriptions()))); | |||
There was a problem hiding this comment.
We can save it ctor to avoid multiple string creation.
|
Is short description unique enough? Should not |
|
@lostmsu - sure, why not |
lostmsu
approved these changes
Oct 4, 2018
|
@MikhailArkhipov FYI, just pulled this PR locally. Whatever issue I had with the assert is gone. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
Tuple protocols are compared by name which makes tuples with different types the same, which causes trouble in analysis hash set when it merges types of function parameters in overloads.