Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support feature names contain Chinese punctuation #1003

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Support feature names contain Chinese punctuation #1003

merged 1 commit into from
Mar 24, 2022

Conversation

Chaoyingz
Copy link
Contributor

Description

Support feature names contain Chinese punctuation.

Motivation and Context

See #1002.

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@Chaoyingz Chaoyingz mentioned this pull request Mar 23, 2022
Closed
@you-n-g
Copy link
Collaborator

you-n-g commented Mar 24, 2022

It looks great! Thanks!

@you-n-g you-n-g merged commit e229b56 into microsoft:main Mar 24, 2022
@Chaoyingz Chaoyingz deleted the support-chinese-punctuation branch March 24, 2022 12:31
@you-n-g you-n-g added the enhancement New feature or request label Apr 24, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@Chaoyingz
Support feature names contain Chinese punctuation (microsoft#1003)
3c40e22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaoyingz @you-n-g