fix_pylint_for_CI #1119
Merged
fix_pylint_for_CI #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you-n-g
reviewed
Jun 9, 2022
qlib/data/dataset/__init__.py
Outdated
| @@ -539,9 +539,6 @@ def __getitem__(self, idx: Union[int, Tuple[object, str], List[int]]): | |||
| data = data.reshape(-1, self.step_len, *data.shape[1:]) | |||
| return data | |||
|
|
|||
| def __len__(self): | |||
qlib/rl/utils/data_queue.py
Outdated
| @@ -145,7 +145,7 @@ def __del__(self): | |||
| def __iter__(self): | |||
| if not self._activated: | |||
| raise ValueError( | |||
| "Need to call activate() to launch a daemon worker " "to produce data into data queue before using it." | |||
| "Need to call activate() to launch a daemon worker, to produce data into data queue before using it." | |||
.github/workflows/test.yml
Outdated
| @@ -72,7 +72,7 @@ jobs: | |||
| run: | | |||
| pip install --upgrade pip | |||
| pip install pylint | |||
| pylint --disable=C0104,C0114,C0115,C0116,C0301,C0302,C0411,C0413,C1802,R0201,R0401,R0801,R0902,R0903,R0911,R0912,R0913,R0914,R0915,R1720,W0105,W0123,W0201,W0511,W0613,W1113,W1514,E0401,E1121,C0103,C0209,R0402,R1705,R1710,R1725,R1735,W0102,W0212,W0221,W0223,W0231,W0237,W0612,W0621,W0622,W0703,W1309,E1102,E1136 --const-rgx='[a-z_][a-z0-9_]{2,30}$' qlib --init-hook "import astroid; astroid.context.InferenceContext.max_inferred = 500" | |||
| pylint --disable=C0104,C0114,C0115,C0116,C0301,C0302,C0411,C0413,C1802,C3001,R0401,R0801,R0902,R0903,R0911,R0912,R0913,R0914,R0915,R1720,W0105,W0123,W0201,W0511,W0613,W1113,W1514,E0401,E1121,C0103,C0209,R0402,R1705,R1710,R1725,R1735,W0102,W0212,W0221,W0223,W0231,W0237,W0612,W0621,W0622,W0703,W1309,E1102,E1136 --const-rgx='[a-z_][a-z0-9_]{2,30}$' qlib --init-hook "import astroid; astroid.context.InferenceContext.max_inferred = 500" | |||
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* fix_pylint_for_CI * reformat_with_black * fix_pylint_C3001 * fix_flake8_error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes