Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1187 error "Please install necessary libs for CatBoostModel." #1246

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

OussCHE
Copy link
Contributor

@OussCHE OussCHE commented Aug 3, 2022

Description

When running 'examples/workflow_by_code.ipynb' in jupyter notebook , you get the following misleading error #1187

177905185-57a43596-b180-4c52-8df9-0e88b95640b4

now the message displayed when running the code is "ModuleNotFoundError. CatBoostModel and CatBoostModel are skipped. (optional: maybe installing lightgbm can fix it.)" that is similar to the other non mandatory packages to install.

Motivation and Context

check #

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@OussCHE OussCHE changed the title Correct the misleading error #1187 "Please install necessary libs for CatBoostModel." fixes #1187 error "Please install necessary libs for CatBoostModel." Aug 5, 2022
@OussCHE
Copy link
Contributor Author

OussCHE commented Aug 8, 2022

@you-n-g I would appreciate your insight about the tests not running for some versions on macos.

@you-n-g
Copy link
Collaborator

you-n-g commented Aug 22, 2022

Thanks!
It looks great. I think the CI error is fixed in the main branch.
Rerunning after merging may fix this error.
Welcome to become one of Qlib's contributors

@you-n-g you-n-g merged commit 8480407 into microsoft:main Aug 22, 2022
@you-n-g you-n-g added the bug Something isn't working label Dec 9, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
…tModel." (microsoft#1246)

* Update __init__.py

* Update __init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants