Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide dtype to empty series to suppress warning; fix typo #1449

Merged
merged 1 commit into from
May 5, 2023
Merged

provide dtype to empty series to suppress warning; fix typo #1449

merged 1 commit into from
May 5, 2023

Conversation

qianyun210603
Copy link
Contributor

Description

  • provide dtype to empty series to suppress below warning 
    D:\Documents\TradeResearch\qlib\qlib\data\data.py:971: FutureWarning: The default dtype for empty Series will be 'object' instead of 'float64' in a future version. Specify a dtype explicitly to silence this warning.
  return pd.Series()
  • fix some typo

Motivation and Context

Adapt latest pandas change and improve code quality

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label Feb 24, 2023
@qianyun210603
Copy link
Contributor Author

@you-n-g would you review please? thanks.

@Fivele-Li Fivele-Li merged commit b084c35 into microsoft:main May 5, 2023
@qianyun210603 qianyun210603 deleted the pit_minor_fix branch June 13, 2023 09:36
@you-n-g you-n-g added bug Something isn't working and removed waiting for triage Cannot auto-triage, wait for triage. labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qianyun210603 @you-n-g @Fivele-Li