Add pre-commit #992
Merged
Add pre-commit #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SunsetWolf will continue to complete this PR |
Closed
|
@SunsetWolf Please add |
|
Working on some errors prompted by flake8. |
you-n-g
commented
Mar 24, 2022
SunsetWolf
force-pushed
the
add_pre_commit
branch
2 times, most recently
from
0d496b5
to
f82a447
Compare
you-n-g
commented
Mar 24, 2022
scripts/get_data.py
Outdated
| @@ -5,5 +5,39 @@ | |||
| from qlib.tests.data import GetData | |||
|
|
|||
|
|
|||
| def get_data( | |||
There was a problem hiding this comment.
Why do you have to change this file?
SunsetWolf
force-pushed
the
add_pre_commit
branch
2 times, most recently
from
05ddd83
to
c725fd0
Compare
you-n-g
commented
Mar 25, 2022
scripts/get_data.py
Outdated
| @@ -6,4 +6,4 @@ | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| fire.Fire(GetData) | |||
| fire.Fire(GetData().qlib_data) | |||
There was a problem hiding this comment.
Are you sure this will work correctly for previous commands?
SunsetWolf
force-pushed
the
add_pre_commit
branch
from
f876e48
to
60aa277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
<! --- Put an
xin all the boxes that apply: --->pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes