Skip to content

Commit

Permalink
Merge branch 'main' into dependabot/bundler/packages/helloworld/rexml…
Browse files Browse the repository at this point in the history
…-3.3.6
  • Loading branch information
Saadnajmi committed Sep 20, 2024
2 parents a0d230c + a87ddb5 commit cad3588
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 15 deletions.
6 changes: 3 additions & 3 deletions .ado/publish.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# It is expected that a `latestStableBranch` variable is set in the pipeline's settings:

# This file defines the build steps to publish a release
name: $(Date:yyyyMMdd).$(Rev:.r)

Expand All @@ -21,6 +19,9 @@ variables:
- group: InfoSec-SecurityResults
- name: tags
value: production,externalfacing
# Remember to update this in previous stable branches when creating a new stable branch
- name : latestStableBranch
value: '0.75-stable'

resources:
repositories:
Expand Down Expand Up @@ -137,7 +138,6 @@ extends:
os: linux
timeoutInMinutes: 90 # how long to run the job before automatically cancelling
cancelTimeoutInMinutes: 5 # how much time to give 'run always even if cancelled tasks' before killing them
condition: eq(variables['Build.SourceBranchName'], 'main')
templateContext:
outputs:
- output: pipelineArtifact
Expand Down
8 changes: 3 additions & 5 deletions .ado/templates/apple-steps-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,11 @@ steps:
# Note, This won't do the actual `git tag` and `git push` as we're doing a dry run.
# We do that as a separate step in `.ado/publish.yml`.
- task: CmdLine@2
displayName: Prepare package for release
displayName: Prepare React Native macOS release
inputs:
script: |
node ./scripts/prepare-package-for-release.js -v "$RNM_PACKAGE_VERSION" --dry-run
env:
# Map the corresponding CircleCI variable since `prepare-package-for-release.js` depends on it.
CIRCLE_BRANCH: $(Build.SourceBranchName)
set -eox pipefail
node scripts/releases/set-rn-version.js -v $RNM_PACKAGE_VERSION --build-type "release"
# Note: This won't actually publish to NPM as we've commented that bit out.
# We do that as a separate step in `.ado/publish.yml`.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Properly import `npm-registry-fetch` in `react-native-macos-init`",
"packageName": "react-native-macos-init",
"email": "sanajmi@microsoft.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-native-macos-init/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-macos-init",
"version": "2.1.0",
"version": "2.1.1",
"description": "CLI to add react-native-macos to an existing react-native project",
"main": "index.js",
"repository": "https://github.com/microsoft/react-native-macos",
Expand Down
3 changes: 1 addition & 2 deletions packages/react-native-macos-init/src/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ import * as validUrl from 'valid-url';
import * as prompts from 'prompts';
import * as findUp from 'find-up';
import * as chalk from 'chalk';
// @ts-ignore
import npmFetch from 'npm-registry';
import * as npmFetch from 'npm-registry-fetch';

const npmConfReg = execSync('npm config get registry').toString().trim();
const NPM_REGISTRY_URL = validUrl.isUri(npmConfReg)
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/React/Views/RCTShadowView.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
@class RCTRootShadowView;
@class RCTSparseArray;

typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, RCTPlatformView *> *viewRegistry); // [macOS]
typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, __kindof RCTPlatformView *> *viewRegistry); // [macOS]

/**
* ShadowView tree mirrors RCT view tree. Every node is highly stateful.
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/React/Views/RCTViewManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
@class RCTSparseArray;
@class RCTUIManager;

typedef void (^RCTViewManagerUIBlock)(RCTUIManager *uiManager, NSDictionary<NSNumber *, RCTPlatformView *> *viewRegistry); // [macOS]
typedef void (^RCTViewManagerUIBlock)(RCTUIManager *uiManager, NSDictionary<NSNumber *, __kindof RCTPlatformView *> *viewRegistry); // [macOS]

@interface RCTViewManager : NSObject <RCTBridgeModule>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ target 'HelloWorld-macOS' do
:path => '../node_modules/react-native-macos',
:hermes_enabled => false,
:fabric_enabled => ENV['RCT_NEW_ARCH_ENABLED'] == '1',
# Flipper is not compatible w/ macOS
:flipper_configuration => FlipperConfiguration.disabled,
# An absolute path to your application root.
:app_path => "#{Pod::Config.instance.installation_root}/.."
)
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"jest",
"Libraries",
"LICENSE",
"local-cli",
"React-Core.podspec",
"react-native.config.js",
"React.podspec",
Expand Down

0 comments on commit cad3588

Please sign in to comment.