Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update responsibleai to scikit-learn 1.5.1 #2570

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Jun 27, 2024

Description

Update responsibleai to scikit-learn 1.5.1

Edit: there were some errors due to issue scikit-learn/scikit-learn#29018 which was fixed in latest scikit-learn 1.5.1. Hopefully upgrading to latest scikit-learn will resolve the econml errors. For more details on error please see:

py-why/EconML#854

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (42a6d27) to head (25f88ad).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2570       +/-   ##
===========================================
+ Coverage   80.34%   92.02%   +11.67%     
===========================================
  Files          66       95       +29     
  Lines        3430     5370     +1940     
===========================================
+ Hits         2756     4942     +2186     
+ Misses        674      428      -246     
Flag Coverage Δ
unittests 92.02% <ø> (+11.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/update-scikit-learn-1.5.0 branch from 0151f34 to 2c5b572 Compare July 5, 2024 20:07
@imatiach-msft imatiach-msft force-pushed the ilmat/update-scikit-learn-1.5.0 branch from 2c5b572 to 25f88ad Compare July 5, 2024 20:08
@imatiach-msft imatiach-msft changed the title Update responsibleai to scikit-learn 1.5.0 Update responsibleai to scikit-learn 1.5.1 Jul 5, 2024
1 similar comment
@imatiach-msft imatiach-msft merged commit 81f6388 into main Jul 5, 2024
99 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/update-scikit-learn-1.5.0 branch July 5, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants