Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): remove duplicate nodeSelector #157

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix(helm): remove duplicate nodeSelector #157

merged 1 commit into from
Mar 27, 2024

Conversation

ronalddb89
Copy link
Contributor

This duplicate will lead to problems using automated CD tools like fluxCD:

2024-03-27T14:57:44.805Z error HelmRelease/retina.retina - Reconciler error Helm install failed: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors: line 119: mapping key "nodeSelector" already defined at line 27

Signed-off-by: Ronald <98810582+ronalddb89@users.noreply.github.com>
@ronalddb89 ronalddb89 requested a review from a team as a code owner March 27, 2024 15:08
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

@rbtr rbtr enabled auto-merge (squash) March 27, 2024 15:12
@ronalddb89 ronalddb89 changed the title remove duplicate nodeSelector fix(helm): remove duplicate nodeSelector Mar 27, 2024
@rbtr rbtr added type/enhancement New feature or request area/infra Test, Release, or CI Infrastructure labels Mar 27, 2024
@rbtr rbtr merged commit 5298eaa into microsoft:main Mar 27, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Test, Release, or CI Infrastructure type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants