Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding devcontainer config #79

Merged
merged 2 commits into from
Mar 20, 2024
Merged

feat: adding devcontainer config #79

merged 2 commits into from
Mar 20, 2024

Conversation

pauldotyu
Copy link
Contributor

Adding Dev Container config and "Open in Codespaces" button at the top of the README.

@pauldotyu pauldotyu requested a review from a team as a code owner March 20, 2024 00:34
Copy link
Contributor

@anubhabMajumdar anubhabMajumdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Paul,
Thanks for your PR. Much appreciated!

Can you add a couple of lines about Testing Done?

.devcontainer/installMoreTools.sh Show resolved Hide resolved
@rbtr
Copy link
Collaborator

rbtr commented Mar 20, 2024

this change fixes the CI issue here #84, should pass checks when updated

README.md Show resolved Hide resolved
@pauldotyu
Copy link
Contributor Author

Can you add a couple of lines about Testing Done?

Sure thing. I was able to install this in a local KIND cluster using the following command but let me do some additional testing and document.

IMAGE_NAMESPACE=microsoft/retina make helm-install

Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@rbtr rbtr merged commit e5f6b8e into microsoft:main Mar 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants