Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Version Policy #479

Merged
merged 2 commits into from
Oct 20, 2020
Merged

HTTP Version Policy #479

merged 2 commits into from
Oct 20, 2020

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Oct 19, 2020 •
edited
Loading

Contributes to #282

@ManickaP ManickaP changed the title [WIP] HTTP Version Policy HTTP Version Policy Oct 20, 2020
@ManickaP ManickaP marked this pull request as ready for review October 20, 2020 16:23
Tratcher
Tratcher approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Try #if NET in the product code as well and we'll see how it works.

Note there's a second half to #282 that we can discuss after this PR which is making RequestProxyOptions configurable per cluster.

src/ReverseProxy/Service/Proxy/RequestProxyOptions.cs Outdated Show resolved Hide resolved
@ManickaP ManickaP merged commit 99b3d78 into microsoft:master Oct 20, 2020
@ManickaP ManickaP deleted the mapichov/282_http_version branch October 20, 2020 18:09
@Tratcher Tratcher added this to the 1.0.0-preview7 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@alnikola alnikola Awaiting requested review from alnikola

@halter73 halter73 Awaiting requested review from halter73

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
YARP 1.0.0-preview7
Development

Successfully merging this pull request may close these issues.
2 participants
@ManickaP @Tratcher