Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement manual configuration binding for proxy config #521

Merged
merged 6 commits into from
Nov 11, 2020
Merged

Implement manual configuration binding for proxy config #521

merged 6 commits into from
Nov 11, 2020

Commits on Nov 10, 2020

  1. Implement manual configuration binding for proxy config 

    - Removed the intermediate *Data types. This makes it clear that there are really 2 models, the input configuration and the runtime model the proxy uses.
- Removed use of IOptionMonitor<T> and bind directly to configuration due to inability to handle parsing or validation errors.

Fixes #481
    @davidfowl
    davidfowl committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    ef3e3e3 View commit details
    Browse the repository at this point in the history

  2. PR feedback, added helpers for parsing primitives from configuration

    @davidfowl
    davidfowl committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    7f99a25 View commit details
    Browse the repository at this point in the history

  3. Some PR feedback

    @davidfowl
    davidfowl committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    469b0ff View commit details
    Browse the repository at this point in the history

  4. More PR feedback 

    - Be more explicit about defaults
- Move defaults to configuration reading
    @davidfowl
    davidfowl committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    866d26b View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Remove null checks, GetSection never returns null

    @davidfowl
    davidfowl committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    8eebe52 View commit details
    Browse the repository at this point in the history

  2. Forgot one

    @davidfowl
    davidfowl committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    9c38a41 View commit details
    Browse the repository at this point in the history