Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't install weak deps by default #110

Merged
merged 2 commits into from
Jun 4, 2024
Merged

don't install weak deps by default #110

merged 2 commits into from
Jun 4, 2024

Conversation

tofay
Copy link
Contributor

@tofay tofay commented Mar 21, 2024

fixes #109

I'll put this as breaking into a 0.3.0 release with a couple of other changes - I want to get rootless mode finished off.

src/lockfile/resolve.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@dsteeley dsteeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially some more tests needed to handle user experience in error scenarios involving weak deps.

@tofay
Copy link
Contributor Author

tofay commented Jun 4, 2024

Potentially some more tests needed to handle user experience in error scenarios involving weak deps.

I've switched to just not allowing weak deps to be installed

@tofay tofay merged commit fddefe6 into main Jun 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skip installation of weak dependencies
2 participants