-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rootless support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofay
force-pushed
the
rootless
branch
3 times, most recently
from
August 26, 2023 22:18
487dfe0
to
6a9dd8d
Compare
bossmc
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Various comments throughout
bossmc
reviewed
Aug 29, 2023
bossmc
reviewed
Aug 29, 2023
bossmc
reviewed
Sep 11, 2023
bossmc
reviewed
Sep 11, 2023
when running as a non-root user, rpmoci will setup a user namespace in which to run
specify dnf logging dir somewhere that doesn't require root access wait on the specific child pid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running as a non-root user, rpmoci will spawn a child in a user namespace, configure that namespace's uid/gid mappings, and re-exec itself in a child process.
this allows it to run as root in the user namespace, which dnf requires, and create container images containing files owned by root, but without requiring root access on the host.