Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rootless support #46

Merged
merged 11 commits into from
Jun 5, 2024
Merged

add rootless support #46

merged 11 commits into from
Jun 5, 2024

Conversation

tofay
Copy link
Contributor

@tofay tofay commented Aug 26, 2023

when running as a non-root user, rpmoci will spawn a child in a user namespace, configure that namespace's uid/gid mappings, and re-exec itself in a child process.

this allows it to run as root in the user namespace, which dnf requires, and create container images containing files owned by root, but without requiring root access on the host.

@tofay tofay force-pushed the rootless branch 3 times, most recently from 487dfe0 to 6a9dd8d Compare August 26, 2023 22:18
@tofay tofay marked this pull request as ready for review August 26, 2023 22:19
Copy link

@bossmc bossmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Various comments throughout

src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@tofay tofay requested a review from bossmc August 31, 2023 20:06
src/main.rs Show resolved Hide resolved
src/subid.rs Outdated Show resolved Hide resolved
@tofay tofay added this to the 0.3.0 milestone Apr 22, 2024
@tofay tofay merged commit 7eeff4d into main Jun 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants