Expose AzureAuthenticationBase._credentialCacheId. (#4914)

microsoft · Sep 7, 2024 · c8a4bb5 · c8a4bb5
1 parent bff8c3d
commit c8a4bb5
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/common/changes/@microsoft/rush/expose_credentialCacheId_2024-09-06-23-00.json b/common/changes/@microsoft/rush/expose_credentialCacheId_2024-09-06-23-00.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Mark `AzureAuthenticationBase._credentialCacheId` as protected in `@rushstack/rush-azure-storage-build-cache-plugin`.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}
diff --git a/common/reviews/api/rush-azure-storage-build-cache-plugin.api.md b/common/reviews/api/rush-azure-storage-build-cache-plugin.api.md
@@ -24,6 +24,8 @@ export abstract class AzureAuthenticationBase {
     // (undocumented)
     protected readonly _azureEnvironment: AzureEnvironmentName;
     // (undocumented)
+    protected get _credentialCacheId(): string;
+    // (undocumented)
     protected abstract readonly _credentialKindForLogging: string;
     // (undocumented)
     protected abstract readonly _credentialNameForCache: string;

diff --git a/rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts b/rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts
@@ -131,7 +131,7 @@ export abstract class AzureAuthenticationBase {
   protected readonly _failoverOrder: Record<LoginFlowType, LoginFlowType | undefined>;
 
   private __credentialCacheId: string | undefined;
-  private get _credentialCacheId(): string {
+  protected get _credentialCacheId(): string {
     if (!this.__credentialCacheId) {
       const cacheIdParts: string[] = [
         this._credentialNameForCache,