[rush] Add suppressedWarnings option

.vscode/settings.json

@@ -17,5 +17,9 @@
     "temp": true,
     "**/test/**/temp": false,
     "coverage": true
+  },
+  "files.associations": {
+    "rush.json": "jsonc",
+    "**/common/config/rush/*.json": "jsonc"
   }
 }

apps/rush-lib/assets/rush-init/rush.json

@@ -270,6 +270,18 @@
    */
   /*[LINE "HYPOTHETICAL"]*/ "hotfixChangeEnabled": false,
 
+  /**
+   * If a warning message includes any substrings listed here, it should be treated as a standard
+   * log message rather than a warning. This prevents inconsequential warning messages caused by
+   * external packages from breaking incremental builds (packages marked as "success with warnings"
+   * will be rebuilt on each rush build).
+   *
+   * For example, certain npm packages with C++ bindings intermittently cause Node to display a warning
+   * starting with "Using a domain property in MakeCallback is deprecated." The source of this warning
+   * has been hard to track down, so it can be added to this list to make incremental builds work.
+   */
+  /*[LINE "HYPOTHETICAL"]*/ "suppressedWarnings": [],
+
   /**
    * (Required) This is the inventory of projects to be managed by Rush.
    *

apps/rush-lib/src/api/RushConfiguration.ts

@@ -122,6 +122,7 @@ export interface IRushConfigurationJson {
   yarnOptions?: IYarnOptionsJson;
   ensureConsistentVersions?: boolean;
   variants?: IRushVariantOptionsJson[];
+  suppressedWarnings?: string[];
 }
 
 /**
@@ -246,6 +247,7 @@ export class RushConfiguration {
   private _variants: {
     [variantName: string]: boolean;
   };
+  private _suppressedWarnings: string[];
 
   // "approvedPackagesPolicy" feature
   private _approvedPackagesPolicy: ApprovedPackagesPolicy;
@@ -734,6 +736,14 @@ export class RushConfiguration {
     return this._ensureConsistentVersions;
   }
 
+  /**
+   * Gets the list of warning message substrings which should be suppressed (treated as standard
+   * log messages rather than warnings).
+   */
+  public get suppressedWarnings(): string[] {
+    return this._suppressedWarnings;
+  }
+
   /**
    * Indicates whether telemetry collection is enabled for Rush runs.
    * @beta
@@ -974,6 +984,8 @@ export class RushConfiguration {
 
     this._ensureConsistentVersions = !!rushConfigurationJson.ensureConsistentVersions;
 
+    this._suppressedWarnings = rushConfigurationJson.suppressedWarnings || [];
+
     this._pnpmOptions = new PnpmOptionsConfiguration(rushConfigurationJson.pnpmOptions || {});
     this._yarnOptions = new YarnOptionsConfiguration(rushConfigurationJson.yarnOptions || { });
 

apps/rush-lib/src/logic/taskRunner/ProjectTask.ts

@@ -160,8 +160,14 @@ export class ProjectTask implements ITaskDefinition {
         });
 
         task.stderr.on('data', (data: string) => {
-          writer.writeError(data);
-          this._hasWarningOrError = true;
+          // If this error matches any of the suppressed warnings from the config, write it to
+          // stdout instead of stderr and don't treat the task as having a warning/error.
+          if (this._rushConfiguration.suppressedWarnings.some((warning: string) => data.indexOf(warning) !== -1)) {
+            writer.write(data);
+          } else {
+            writer.writeError(data);
+            this._hasWarningOrError = true;
+          }
         });
 
         return new Promise((resolve: (status: TaskStatus) => void, reject: (error: TaskError) => void) => {

apps/rush-lib/src/schemas/rush.schema.json

@@ -234,7 +234,14 @@
         }
       },
       "additionalProperties": false
-    }
+    },
+    "suppressedWarnings": {
+      "description": "A list of warning messages which should be treated as standard log messages instead of warnings.",
+      "type": "array",
+      "items": {
+        "type": "string"
+      }
+}
   },
   "additionalProperties": false,
   "required": [

common/changes/@microsoft/rush/ignore-warnings_2019-04-10-19-30.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "Add suppressedWarnings option",
+      "packageName": "@microsoft/rush",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush",
+  "email": "ecraig12345@users.noreply.github.com"
+}

common/reviews/api/rush-lib.api.md

@@ -259,6 +259,7 @@ export class RushConfiguration {
     readonly rushJsonFolder: string;
     readonly rushLinkJsonFilename: string;
     readonly shrinkwrapFilePhrase: string;
+    readonly suppressedWarnings: string[];
     // @beta
     readonly telemetryEnabled: boolean;
     readonly tempShrinkwrapFilename: string;

rush.json

@@ -223,6 +223,18 @@
    */
   // "hotfixChangeEnabled": false,
 
+  /**
+   * If a warning message includes any substrings listed here, it should be treated as a standard
+   * log message rather than a warning. This prevents inconsequential warning messages caused by
+   * external packages from breaking incremental builds (packages marked as "success with warnings"
+   * will be rebuilt on each rush build).
+   *
+   * For example, certain npm packages with C++ bindings intermittently cause Node to display a warning
+   * starting with "Using a domain property in MakeCallback is deprecated." The source of this warning
+   * has been hard to track down, so it can be added to this list to make incremental builds work.
+   */
+  // "suppressedWarnings": [],
+
   /**
    * (Required) This is the inventory of projects to be managed by Rush.
    *