Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Update rush NodeJS warning messages and add option to suppress non-LTS warning messages. #1388

Merged
merged 18 commits into from
Jul 23, 2019

Conversation

iclanton
Copy link
Member

@iclanton iclanton commented Jul 16, 2019

Fixes #1373

apps/rush-lib/src/api/Rush.ts Outdated Show resolved Hide resolved
@octogonz
Copy link
Collaborator

@iclanton Could you also test this using a nightly build (e.g. where process.version returns a string like "v10.0.0-nightly20171114803cacd228")? We should make sure an appropriate warning is printed in that case as well.

@mikeharder
Copy link
Contributor

@iclanton Could you also test this using a nightly build (e.g. where process.version returns a string like "v10.0.0-nightly20171114803cacd228")? We should make sure an appropriate warning is printed in that case as well.

You could also use a nightly of v13 if you want to test a version newer than v12.

Copy link
Collaborator

@octogonz octogonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See notes

apps/rush/src/start.ts Outdated Show resolved Hide resolved
@iclanton iclanton merged commit c81518d into microsoft:master Jul 23, 2019
@iclanton iclanton deleted the ianc/updates-to-rush-messages branch July 23, 2019 00:17
@octogonz octogonz mentioned this pull request May 29, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rush] Add support for "Current" Node version (12.x)
4 participants