Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rush] Add hooks for pre and post rushx events #4286

Merged
merged 32 commits into from
Oct 6, 2023
Merged

[rush] Add hooks for pre and post rushx events #4286

merged 32 commits into from
Oct 6, 2023

Commits on Aug 18, 2023

  1. adding pre and post rushx events

    @nebosite
    nebosite committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    bbba972 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Adding Pro and Post event hooks to rushx

    @nebosite
    nebosite committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    bfff506 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Move exitcode handling out of _lauchRushXInternal

    @nebosite
    nebosite committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    6d29a0e View commit details
    Browse the repository at this point in the history

  2. Whoops accidentally checked in test code

    @nebosite
    nebosite committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    406fb69 View commit details
    Browse the repository at this point in the history

  3. Special handling for process errors

    @nebosite
    nebosite committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    d936b16 View commit details
    Browse the repository at this point in the history

  4. Quote unknown arguments

    @nebosite
    nebosite committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    8050af6 View commit details
    Browse the repository at this point in the history

  5. Rename INSIDERUSH to _RUSH_SUPPRESS_HOOKS

    @nebosite
    nebosite committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    454e113 View commit details
    Browse the repository at this point in the history

  6. Add debug parameter to rushx so it can be passed to hooks

    @nebosite
    nebosite committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    9517be9 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Don't print hook suppressed messages on recursive calls

    @nebosite
    nebosite committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    39d1011 View commit details
    Browse the repository at this point in the history

  2. Add --ignorehooks and fix bug in hook runner

    @nebosite
    nebosite committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f8a0be2 View commit details
    Browse the repository at this point in the history

  3. Don't try to run hooks on --help

    @nebosite
    nebosite committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    657eb84 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. responding to code reviews

    @nebosite
    nebosite committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    3ba9901 View commit details
    Browse the repository at this point in the history

  2. Rush change

    @nebosite
    nebosite committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    738b55f View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Merge remote-tracking branch 'remotes/origin/main' into neboste/rushx… 

    …_hooks

# Conflicts:
#	libraries/rush-lib/src/cli/RushXCommandLine.ts
#	libraries/rush-lib/src/utilities/Utilities.ts
    @octogonz
    octogonz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    327fbe4 View commit details
    Browse the repository at this point in the history

  2. Fix some build warnings

    @octogonz
    octogonz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    3815b1a View commit details
    Browse the repository at this point in the history

  3. Fix a test failure (but I have some questions about this variable, se… 

    …e PR discussion):

[test:jest]   ● CLI › rushx should pass args to scripts
[test:jest]
[test:jest]     The command failed with exit code 1
[test:jest]     Error: The following environment variables were found with the "RUSH_" prefix, but they are not recognized by this version of Rush: RUSH_SUPPRESS_HOOKS
    @octogonz
    octogonz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    c89d1dc View commit details
    Browse the repository at this point in the history

  4. Add more detail to change file

    @octogonz
    octogonz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    a93c500 View commit details
    Browse the repository at this point in the history

  5. Document event hooks in rush.json template

    @octogonz
    octogonz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    3d406c6 View commit details
    Browse the repository at this point in the history

  6. Rename RUSH_SUPPRESS_HOOKS to _RUSH_SUPPRESS_RUSHX_HOOKS (because it … 

    …seems to only apply to rushx hooks), and make it internal (in case we need to refine this further in the future)
    @octogonz
    octogonz committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ff5d1b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Rename EnvironmentVariableNames.RUSH_LIB_PATH to _RUSH_LIB_PATH to ma… 

    …tch the actual environment variable

This is not a breaking API change, because the environment variable is internal.
    @octogonz
    octogonz committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    914ab21 View commit details
    Browse the repository at this point in the history

  2. Remove "-i" parameter per PR discussion

    @octogonz
    octogonz committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    aaee1f2 View commit details
    Browse the repository at this point in the history

  3. Refactor arguments to _launchRushXInternal

    @nebosite
    nebosite committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3065543 View commit details
    Browse the repository at this point in the history

  4. Refactor environment variable name for hook suppression

    @nebosite
    nebosite committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    b7f94fd View commit details
    Browse the repository at this point in the history

  5. Handle rushx hook errors as benign

    @nebosite
    nebosite committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ee01b51 View commit details
    Browse the repository at this point in the history

  6. rolling back accidental change to rush and rushx scripts

    @nebosite
    nebosite committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    710af8a View commit details
    Browse the repository at this point in the history

  7. Add environment var _RUSH_ORIGINAL_ARGS

    @nebosite
    nebosite committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2bd1390 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Rename _RUSH_ORIGINAL_ARGS to a public environment variable RUSH_INVO… 

    …KED_ARGS, whose concept is similar to RUSH_INVOKED_FOLDER

Fix a bug where EnvironmentConfiguration.validate() did not accept this variable
    @octogonz
    octogonz committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5618ca8 View commit details
    Browse the repository at this point in the history

  2. RUSH_INVOKED_ARGS should only be assigned when invoking hook scripts … 

    …(not regular NPM lifecycle scripts)
    @octogonz
    octogonz committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6da0cf6 View commit details
    Browse the repository at this point in the history

  3. putting back alreadyReportedNodeTooNewError

    @nebosite
    nebosite committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    125f25c View commit details
    Browse the repository at this point in the history

  4. rolling back accidental change to rush and rushx scripts

    @nebosite
    nebosite committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    04c723d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'neboste/rushx_hooks' of github.com:nebosite/rushstack i… 

    …nto neboste/rushx_hooks
    @nebosite
    nebosite committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9236fac View commit details
    Browse the repository at this point in the history

  6. make _launchRushXInternal private

    @nebosite
    nebosite committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    00d2c19 View commit details
    Browse the repository at this point in the history