Will/lockfile pnpm8 support #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william2958
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
reviewed
Sep 3, 2023
common/changes/@rushstack/lockfile-explorer/will-lockfile-pnpm8-support_2023-08-31-23-03.json
Outdated
Show resolved
Hide resolved
…8-support_2023-08-31-23-03.json Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
iclanton
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR adds the ability for lockfile explorer to read pnpm 8 lockfiles correctly (pnpm lockfiles that are using the v6 spec)
Fixes #4254
Details
v6 of the pnpm lockfile slightly changes the way entries are recorded, replacing the splitter between the package and it's version with a '@' instead of a '/'. This MR just adapts the new format to the old format so the explorer can read the lockfile correctly.
How it was tested
Tested manually
Impacted documentation