[typings-generator] Add some options to typings generation and introduce a Heft plugin for generating loc file typings. #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
iclanton
changed the title
D4N14L
approved these changes
Aug 17, 2024
heft-plugins/heft-localization-typings-plugin/src/LocalizationTypingsPlugin.ts
Outdated
Show resolved
Hide resolved
heft-plugins/heft-localization-typings-plugin/src/LocalizationTypingsPlugin.ts
Outdated
Show resolved
Hide resolved
heft-plugins/heft-localization-typings-plugin/src/LocalizationTypingsPlugin.ts
Outdated
Show resolved
Hide resolved
libraries/typings-generator/src/StringValuesTypingsGenerator.ts
Outdated
Show resolved
Hide resolved
heft-plugins/heft-localization-typings-plugin/src/LocalizationTypingsPlugin.ts
Outdated
Show resolved
Hide resolved
heft-plugins/heft-localization-typings-plugin/src/LocalizationTypingsPlugin.ts
Outdated
Show resolved
Hide resolved
heft-plugins/heft-localization-typings-plugin/src/LocalizationTypingsPlugin.ts
Outdated
Show resolved
Hide resolved
heft-plugins/heft-localization-typings-plugin/src/LocalizationTypingsPlugin.ts
Outdated
Show resolved
Hide resolved
heft-plugins/heft-localization-typings-plugin/src/LocalizationTypingsPlugin.ts
Outdated
Show resolved
Hide resolved
heft-plugins/heft-localization-typings-plugin/src/schemas/options.schema.json
Outdated
Show resolved
Hide resolved
D4N14L
approved these changes
Aug 21, 2024
heft-plugins/heft-localization-typings-plugin/src/schemas/options.schema.json
Outdated
Show resolved
Hide resolved
iclanton
force-pushed
the
loc-typings-heft-plugin
branch
3 times, most recently
from
c6312e6
to
a9747a4
Compare
iclanton
force-pushed
the
loc-typings-heft-plugin
branch
from
dcafe71
to
63d137d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add more options to customize
StringValuestypingsGeneratorand the typings generator in localization-utilities, and introduce a Heft plugin for generating localization file typings.How it was tested
Tested in a repo that uses this functionality.