[api-extractor] Fix an issue where .d.ts trimming did not work for exported variable declaration #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
reviewed
Nov 15, 2018
| @@ -219,6 +219,8 @@ export declare class TypeReferencesInAedoc { | |||
|
|
|||
| declare const unexportedCustomSymbol: unique symbol; | |||
|
|
|||
| /* Excluded from this release type: VARIABLE */ | |||
There was a problem hiding this comment.
Is this right? Shouldn't there be a variable here? #Resolved
There was a problem hiding this comment.
It is marked as /** @alpha */ whereas you're looking at the dist/public output #Resolved
iclanton
approved these changes
Nov 15, 2018
| @@ -246,6 +246,8 @@ export declare class TypeReferencesInAedoc { | |||
|
|
|||
| declare const unexportedCustomSymbol: unique symbol; | |||
|
|
|||
| export declare const VARIABLE: string; | |||
There was a problem hiding this comment.
Should this have a comment? #WontFix
There was a problem hiding this comment.
Good point.
I have fixed this issue in my AE7 branch, but I won't backport the fix to AE6, because in this branch the _getReleaseTagForDeclaration() logic doesn't save the comment that it found.
AE7 will be out soon.
In reply to: 234018505 [](ancestors = 234018505)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GitHub #936