-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds SGX build using custom 1ES GitHub SGX pool #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ivarprudnikov
commented
Aug 22, 2024
•
edited
Loading
edited
- ADO build pipeline triggers sometimes misfire and leave us in a state where SGX builds do not run, one PR slipped through already
- Main branch builds in ADO pipelines require manual intervention to make sure the build runs
- Created a separate dedicated SGX pool in Azure and scoped it to this repository
- GitHub Action now uses a matrix where one build is virtual as was already and the other uses the custom pool
- Similar to how CCF run their builds (sgx was removed recently): https://github.com/microsoft/CCF/blob/main/.github/workflows/ci.yml
ivarprudnikov
changed the title
WIP adds SGX build
Adds SGX build using custom 1ES GitHub SGX pool
Aug 23, 2024
achamayou
approved these changes
Aug 23, 2024
…ed certs to mitigate issue on SGX tests that use OpneSSL 1.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.