Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds SGX build using custom 1ES GitHub SGX pool #213

Merged
merged 13 commits into from
Aug 23, 2024

Conversation

ivarprudnikov
Copy link
Member

@ivarprudnikov ivarprudnikov commented Aug 22, 2024

  • ADO build pipeline triggers sometimes misfire and leave us in a state where SGX builds do not run, one PR slipped through already
  • Main branch builds in ADO pipelines require manual intervention to make sure the build runs
  • Created a separate dedicated SGX pool in Azure and scoped it to this repository
  • GitHub Action now uses a matrix where one build is virtual as was already and the other uses the custom pool
  • Similar to how CCF run their builds (sgx was removed recently): https://github.com/microsoft/CCF/blob/main/.github/workflows/ci.yml

@ivarprudnikov ivarprudnikov changed the title adds SGX build WIP adds SGX build Aug 22, 2024
@ivarprudnikov ivarprudnikov changed the title WIP adds SGX build Adds SGX build using custom 1ES GitHub SGX pool Aug 23, 2024
@ivarprudnikov ivarprudnikov marked this pull request as ready for review August 23, 2024 12:53
…ed certs to mitigate issue on SGX tests that use OpneSSL 1.1.1
@ivarprudnikov ivarprudnikov enabled auto-merge (squash) August 23, 2024 13:51
@ivarprudnikov ivarprudnikov merged commit dd96110 into main Aug 23, 2024
16 checks passed
@ivarprudnikov ivarprudnikov deleted the feat/sgx-build-on-github-actions branch August 23, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants