Add explicit @nonnull to query providers constructor arguments

microsoft · Aug 21, 2024 · 07e1f5b · 07e1f5b
1 parent 3ae3fc3
commit 07e1f5b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/...ava/com/microsoft/semantickernel/connectors/data/mysql/MySQLVectorStoreQueryProvider.java b/...ava/com/microsoft/semantickernel/connectors/data/mysql/MySQLVectorStoreQueryProvider.java
@@ -13,6 +13,7 @@
 import com.microsoft.semantickernel.exceptions.SKException;
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
+import javax.annotation.Nonnull;
 import javax.sql.DataSource;
 import java.sql.Connection;
 import java.sql.PreparedStatement;
@@ -26,8 +27,11 @@ public class MySQLVectorStoreQueryProvider extends
     private final ObjectMapper objectMapper;
 
     @SuppressFBWarnings("EI_EXPOSE_REP2")
-    private MySQLVectorStoreQueryProvider(DataSource dataSource, String collectionsTable,
-        String prefixForCollectionTables, ObjectMapper objectMapper) {
+    private MySQLVectorStoreQueryProvider(
+            @Nonnull DataSource dataSource,
+            @Nonnull String collectionsTable,
+            @Nonnull String prefixForCollectionTables,
+            @Nonnull ObjectMapper objectMapper) {
         super(dataSource, collectionsTable, prefixForCollectionTables);
         this.dataSource = dataSource;
         this.objectMapper = objectMapper;

diff --git a/...microsoft/semantickernel/connectors/data/postgres/PostgreSQLVectorStoreQueryProvider.java b/...microsoft/semantickernel/connectors/data/postgres/PostgreSQLVectorStoreQueryProvider.java
@@ -14,6 +14,7 @@
 import com.microsoft.semantickernel.exceptions.SKException;
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
+import javax.annotation.Nonnull;
 import javax.sql.DataSource;
 import java.sql.Connection;
 import java.sql.PreparedStatement;
@@ -27,6 +28,7 @@
 
 public class PostgreSQLVectorStoreQueryProvider extends
     JDBCVectorStoreDefaultQueryProvider implements JDBCVectorStoreQueryProvider {
+
     private final Map<Class<?>, String> supportedKeyTypes;
     private final Map<Class<?>, String> supportedDataTypes;
     private final Map<Class<?>, String> supportedVectorTypes;
@@ -37,8 +39,11 @@ public class PostgreSQLVectorStoreQueryProvider extends
     private final ObjectMapper objectMapper;
 
     @SuppressFBWarnings("EI_EXPOSE_REP2")
-    private PostgreSQLVectorStoreQueryProvider(DataSource dataSource, String collectionsTable,
-        String prefixForCollectionTables, ObjectMapper objectMapper) {
+    private PostgreSQLVectorStoreQueryProvider(
+            @Nonnull DataSource dataSource,
+            @Nonnull String collectionsTable,
+            @Nonnull String prefixForCollectionTables,
+            @Nonnull ObjectMapper objectMapper) {
         super(dataSource, collectionsTable, prefixForCollectionTables);
         this.dataSource = dataSource;
         this.collectionsTable = collectionsTable;