-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Copilot Chat: Update to newest SK nuget (#1811)
### Motivation and Context Update CopilotChat sample to the latest SK nuget version, absorbing breaking changes. **I've done zero testing on this, other than "it builds", so we'll want to validate it before merging.** cc: @shawncal This cleans up some cruft related to skill definitions, though there's still likely more that can be done for someone more familiar than I am with this code. I expect we'll be able to clean it up further once the exception handling changes land, as there's a lot of code dedicated to checking whether an error has occurred and short-circuiting if one has. (@SergeyMenshykh, this would be a good one to pay attention to, in particular around how exceptions propagate out of semantic functions instead of relying on manual checking of the returned context.) ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com> Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>
- Loading branch information
1 parent
dcadd48
commit 7c8b239
Showing
7 changed files
with
80 additions
and
177 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.