Renaming some methods per PM feedback.

microsoft · Oct 4, 2024 · ae211d5 · ae211d5
1 parent f4fff45
commit ae211d5
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/dotnet/samples/GettingStartedWithProcesses/Step01/Step01_Processes.cs b/dotnet/samples/GettingStartedWithProcesses/Step01/Step01_Processes.cs
@@ -38,7 +38,7 @@ public async Task UseSimpleProcessAsync()
 
         // Define the behavior when the process receives an external event
         process
-            .OnExternalEvent(ChatBotEvents.StartProcess)
+            .OnInputEvent(ChatBotEvents.StartProcess)
             .SendEventTo(new ProcessFunctionTargetBuilder(introStep));
 
         // When the intro is complete, notify the userInput step

diff --git a/dotnet/samples/GettingStartedWithProcesses/Step02/Step02_AccountOpening.cs b/dotnet/samples/GettingStartedWithProcesses/Step02/Step02_AccountOpening.cs
@@ -30,7 +30,7 @@ private KernelProcess SetupAccountOpeningProcess<TUserInputStep>() where TUserIn
         var crmRecordStep = process.AddStepFromType<CRMRecordCreationStep>();
         var welcomePacketStep = process.AddStepFromType<WelcomePacketStep>();
 
-        process.OnExternalEvent(AccountOpeningEvents.StartProcess)
+        process.OnInputEvent(AccountOpeningEvents.StartProcess)
             .SendEventTo(new ProcessFunctionTargetBuilder(newCustomerFormStep, CompleteNewCustomerFormStep.Functions.NewAccountWelcome));
 
         // When the welcome message is generated, send message to displayAssistantMessageStep

diff --git a/dotnet/src/Experimental/Process.Core/ProcessBuilder.cs b/dotnet/src/Experimental/Process.Core/ProcessBuilder.cs
@@ -133,7 +133,7 @@ public ProcessBuilder AddStepFromProcess(ProcessBuilder kernelProcess)
     /// </summary>
     /// <param name="eventId">The Id of the external event.</param>
     /// <returns>An instance of <see cref="ProcessStepEdgeBuilder"/></returns>
-    public ProcessEdgeBuilder OnExternalEvent(string eventId)
+    public ProcessEdgeBuilder OnInputEvent(string eventId)
     {
         return new ProcessEdgeBuilder(this, eventId);
     }
@@ -144,7 +144,7 @@ public ProcessEdgeBuilder OnExternalEvent(string eventId)
     /// <param name="eventId">The Id of the event</param>
     /// <returns>An instance of <see cref="ProcessFunctionTargetBuilder"/></returns>
     /// <exception cref="KernelException"></exception>
-    public ProcessFunctionTargetBuilder GetTargetForExternalEvent(string eventId)
+    public ProcessFunctionTargetBuilder WhereInputEventIs(string eventId)
     {
         Verify.NotNullOrWhiteSpace(eventId);
 

diff --git a/dotnet/src/Experimental/Process.UnitTests/ProcessBuilderTests.cs b/dotnet/src/Experimental/Process.UnitTests/ProcessBuilderTests.cs
@@ -73,7 +73,7 @@ public void OnExternalEventCreatesEdgeBuilder()
         var processBuilder = new ProcessBuilder(ProcessName);
 
         // Act
-        var edgeBuilder = processBuilder.OnExternalEvent(EventId);
+        var edgeBuilder = processBuilder.OnInputEvent(EventId);
 
         // Assert
         Assert.NotNull(edgeBuilder);

diff --git a/dotnet/src/IntegrationTests/Processes/ProcessTests.cs b/dotnet/src/IntegrationTests/Processes/ProcessTests.cs
@@ -70,7 +70,7 @@ public async Task NestedProcessOuterToInnerWorksAsync()
 
         // Route the last step of the outer process to trigger the external event that starts the inner process
         processBuilder.Steps[1].OnEvent(ProcessTestsEvents.OutputReadyInternal)
-            .SendEventTo(nestedProcessStep.GetTargetForExternalEvent(ProcessTestsEvents.StartProcess));
+            .SendEventTo(nestedProcessStep.WhereInputEventIs(ProcessTestsEvents.StartProcess));
 
         // Build the outer process
         var process = processBuilder.Build();
@@ -111,8 +111,8 @@ public async Task NestedProcessInnerToOuterWorksWithPublicEventAsync()
         var nestedProcessStep = processBuilder.AddStepFromProcess(this.CreateLinearProcess("Inner"));
 
         // Add a new external event to start the outer process and handoff to the inner process directly
-        processBuilder.OnExternalEvent(ProcessTestsEvents.StartInnerProcess)
-            .SendEventTo(nestedProcessStep.GetTargetForExternalEvent(ProcessTestsEvents.StartProcess));
+        processBuilder.OnInputEvent(ProcessTestsEvents.StartInnerProcess)
+            .SendEventTo(nestedProcessStep.WhereInputEventIs(ProcessTestsEvents.StartProcess));
 
         // Route the last step of the inner process to trigger the echo step of the outer process
         nestedProcessStep.OnEvent(ProcessTestsEvents.OutputReadyPublic)
@@ -155,8 +155,8 @@ public async Task NestedProcessInnerToOuterDoesNotWorkWithInternalEventAsync()
         var nestedProcessStep = processBuilder.AddStepFromProcess(this.CreateLinearProcess("Inner"));
 
         // Add a new external event to start the outer process and handoff to the inner process directly
-        processBuilder.OnExternalEvent(ProcessTestsEvents.StartInnerProcess)
-            .SendEventTo(nestedProcessStep.GetTargetForExternalEvent(ProcessTestsEvents.StartProcess));
+        processBuilder.OnInputEvent(ProcessTestsEvents.StartInnerProcess)
+            .SendEventTo(nestedProcessStep.WhereInputEventIs(ProcessTestsEvents.StartProcess));
 
         // Route the last step of the inner process to trigger the echo step of the outer process
         nestedProcessStep.OnEvent(ProcessTestsEvents.OutputReadyInternal)
@@ -185,7 +185,7 @@ private ProcessBuilder CreateLinearProcess(string name)
         var echoStep = processBuilder.AddStepFromType<EchoStep>();
         var repeatStep = processBuilder.AddStepFromType<RepeatStep>();
 
-        processBuilder.OnExternalEvent(ProcessTestsEvents.StartProcess)
+        processBuilder.OnInputEvent(ProcessTestsEvents.StartProcess)
             .SendEventTo(new ProcessFunctionTargetBuilder(echoStep));
 
         echoStep.OnFunctionResult(nameof(EchoStep.Echo))