Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: unable to debug unit tests #4515

Closed
moonbox3 opened this issue Jan 8, 2024 · 0 comments · Fixed by #4519
Closed

Python: unable to debug unit tests #4515

moonbox3 opened this issue Jan 8, 2024 · 0 comments · Fixed by #4519
Assignees
@moonbox3
Labels
python Pull requests for the Python Semantic Kernel

Comments

@moonbox3
Copy link
Contributor

moonbox3 commented Jan 8, 2024

Describe the bug
It appears after adding config for Python code coverage, one is unable to debug unit tests. The tests run, but breakpoints aren't hit.

To Reproduce
Steps to reproduce the behavior:

  1. Get latest code
  2. Place a breakpoint in any unit test
  3. Try to debug it
  4. The test finishes without the breakpoint being hit

Expected behavior
We should be able to hit the break point and debug
@moonbox3 moonbox3 self-assigned this Jan 8, 2024
@shawncal shawncal added python Pull requests for the Python Semantic Kernel triage labels Jan 8, 2024
@moonbox3 moonbox3 removed the triage label Jan 8, 2024
@moonbox3 moonbox3 mentioned this issue Jan 8, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2024
@moonbox3
Python: Remove code coverage def in pyproject.toml which doesn't allo…
63a7520 
…w one to debug unit tests (#4519)

### Motivation and Context

Fixes #4515.

After adding some test code coverage config to the pyproject.toml, one
isn't able to debug unit tests. Removing this config allows one to debug
the unit tests again.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

The code coverage config is still working for other tasks, so this
doesn't remove it completely.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

Co-authored-by: Evan Mattson <evan.mattson@microsoft.com>
Bryan-Roe pushed a commit to Bryan-Roe/semantic-kernel that referenced this issue Oct 6, 2024
@moonbox3
Python: Remove code coverage def in pyproject.toml which doesn't allo…
dac6f4a 
…w one to debug unit tests (microsoft#4519)

### Motivation and Context

Fixes microsoft#4515.

After adding some test code coverage config to the pyproject.toml, one
isn't able to debug unit tests. Removing this config allows one to debug
the unit tests again.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

The code coverage config is still working for other tasks, so this
doesn't remove it completely.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

Co-authored-by: Evan Mattson <evan.mattson@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moonbox3 moonbox3

Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
2 participants
@moonbox3 @shawncal