Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: CancelKernelEventArgs is marked with SKEXP0003 Experimental Attribute instead of SKEXP0004 #4650

Closed
Gwenn-B opened this issue Jan 17, 2024 · 0 comments · Fixed by #4657
Closed

.Net: CancelKernelEventArgs is marked with SKEXP0003 Experimental Attribute instead of SKEXP0004 #4650

Gwenn-B opened this issue Jan 17, 2024 · 0 comments · Fixed by #4657
Assignees
@markwallace-microsoft
Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code

Comments

@Gwenn-B
Copy link
Contributor

Gwenn-B commented Jan 17, 2024

Describe the bug
CancelKernelEventArgs is marked with SKEXP0003 Experimental Attribute instead of SKEXP0004
Documentation states that SKEXP0004 is for Kernel Events and SKEXP0003 is for Memory connectors.
All others Kernel Events arguments are tagged with SKEXP0004

To Reproduce
N/A

Expected behavior
CancelKernelEventArgs with SKEXP0004 Experimental Attribute.

Platform

  • OS: Windows
  • IDE: Visual Studio
  • Language: C#
  • Source: SemanticKernel 1.1.0
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code triage labels Jan 17, 2024
@github-actions github-actions bot changed the title CancelKernelEventArgs is marked with SKEXP0003 Experimental Attribute instead of SKEXP0004 .Net: CancelKernelEventArgs is marked with SKEXP0003 Experimental Attribute instead of SKEXP0004 Jan 17, 2024
@Gwenn-B Gwenn-B mentioned this issue Jan 17, 2024
Merged
4 tasks
@matthewbolanos matthewbolanos added bug Something isn't working and removed triage labels Jan 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 19, 2024
@Gwenn-B
.Net: CancelKernelEventArgs is marked with SKEXP0003 Experimental Att…
a919536 
…ribute instead of SKEXP0004 (#4657)

### Motivation and Context
Closes #4650

### Description

Replace [Experimental("SKEXP0003")] by [Experimental("SKEXP0004")] above
CancelKernelEventArgs type, to follow
[documentation](https://github.com/microsoft/semantic-kernel/blob/main/dotnet/docs/EXPERIMENTS.md)

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Bryan-Roe pushed a commit to Bryan-Roe/semantic-kernel that referenced this issue Oct 6, 2024
@Gwenn-B
.Net: CancelKernelEventArgs is marked with SKEXP0003 Experimental Att…
d5b824e 
…ribute instead of SKEXP0004 (microsoft#4657)

### Motivation and Context
Closes microsoft#4650

### Description

Replace [Experimental("SKEXP0003")] by [Experimental("SKEXP0004")] above
CancelKernelEventArgs type, to follow
[documentation](https://github.com/microsoft/semantic-kernel/blob/main/dotnet/docs/EXPERIMENTS.md)

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
4 participants
@matthewbolanos @shawncal @Gwenn-B @markwallace-microsoft