.Net: Pinecone connector PineconeClient will not deserialize pod_type due to converter priority

[royaltie-roman]

Describe the bug

In PineconeClient there is a line that always breaks

public async Task<PineconeIndex?> DescribeIndexAsync(string indexName, CancellationToken cancellationToken = default)
{
      // .... 
      PineconeIndex? indexDescription = JsonSerializer.Deserialize<PineconeIndex>(responseContent, this._jsonSerializerOptions);
      // .... 
}

with the following error:

The JSON value could not be converted to Microsoft.SemanticKernel.Connectors.Memory.Pinecone.Model.PodType. Path: $.database.pod_type | LineNumber: 0 | BytePositionInLine: 144.

My research shows that this is because in PineconeUtils.cs there is line

    internal static JsonSerializerOptions DefaultSerializerOptions { get; } = new()
    {
        // ....
        Converters = { new JsonStringEnumConverter(JsonNamingPolicy.CamelCase) },
    };

So, custom converter PodTypeJsonConverter for PodType enum will be added AFTER the enum converter and, as result, will never be called because default converter will error out.

To Reproduce

Happens on every call to get Pinecone index info.

Expected behavior

Custom converter for PodType should be called first.

Workaround

To whoever has the same issue, here is ABSOLUTELY UGLY workaround

    // Call this somewhere from static constructor
    public static void FixPineconePodTypeConverter()
    {
        var pineconeUtilsType = typeof(PineconeUtils);
        var optionsProperty = pineconeUtilsType.GetProperty("DefaultSerializerOptions", BindingFlags.NonPublic | BindingFlags.Static)!;
        var jsonOptions = (JsonSerializerOptions)optionsProperty.GetValue(null)!;
        var converterType = pineconeUtilsType.Assembly.GetType("Microsoft.SemanticKernel.Connectors.Memory.Pinecone.Model.PodTypeJsonConverter", true)!;
        var converterInstance = (JsonConverter<PodType>)Activator.CreateInstance(converterType, true)!;
        if (jsonOptions.Converters.All(c => c.GetType() != converterType))
        {
            jsonOptions.Converters.Insert(0, converterInstance!);
        }
    }

[royaltie-roman]

I can also add that starter plan is now returning nano instead. This value is not a part of PodType enum, so it will also break for everyone using free plan I guess. This is another issue though. Just sayin.

[github-actions]

This issue is stale because it has been open for 90 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 14 days since being marked as stale.