ADR to add support for multiple native function arguments of many types #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
force-pushed
the
users/markwallace/adr-support-multiple-native-function-args
branch
from
c4b6873
to
c474b72
Compare
shawncal
approved these changes
Jun 19, 2023
shawncal
force-pushed
the
users/markwallace/adr-support-multiple-native-function-args
branch
from
c474b72
to
c9b78f9
Compare
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…es (microsoft#1554) ### Motivation and Context Please help reviewers and future users, providing the following information: 1. Why is this change required? Move native functions closer to a normal C# experience. ### Description ADR to record this decision: microsoft#1195 ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
markwallace-microsoft
deleted the
users/markwallace/adr-support-multiple-native-function-args
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Please help reviewers and future users, providing the following information:
Description
ADR to record this decision: #1195
Contribution Checklist
dotnet format