Removing TrustService from Kernel.Core (to become extension) #1895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
TrustService
, along with related types likeTrustAwareString
showcase a really interesting pattern, but we'd like to repackage them into aSemanticKernal.Extensions.Trust
package with a lot more configurability, rather than baking these into the SK Core. With the upcoming support for pre- and post- completion hooks in a Plan, we believe we can build a better solution that leverages those hooks, but is optional, configurable, and fully replaceable if our solution doesn't meet your needs.Other reasons:
TrustAwareString
type is at odds with the transition we're making to allow any objects (not just strings) in SK's context variables, function args, and return types.TrustAwareString
objects can be manipulated by static casts, and are therefore unreliable.Description
TrustService
,TrustAwareString
,IsSensitive
and related references from the SK.Core and Abstractions packages.**These will be added back in the form of a new
SemanticKernel.Extensions.Trust
namespace with optional packages and more features, including an auditable trust chain.Contribution Checklist
dotnet format