Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Update to Service registry pattern #1923

Conversation

johnoliver
Copy link
Member

@johnoliver johnoliver commented Jul 10, 2023

Resolves #1628

Also setKernelConfig -> withKernelConfig, to be in keeping with other builder functions

@johnoliver johnoliver added the java Issue or PR regarding Java code label Jul 10, 2023
@johnoliver johnoliver requested a review from a team as a code owner July 10, 2023 15:57
@johnoliver johnoliver force-pushed the serviceregistry-2 branch 2 times, most recently from 2a21ae0 to 091028c Compare July 10, 2023 15:58
@markwallace-microsoft markwallace-microsoft merged commit 2212d46 into microsoft:experimental-java Jul 10, 2023
6 checks passed
johnoliver added a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
Resolves microsoft#1628 

Also setKernelConfig -> withKernelConfig, to be in keeping with other
builder functions
johnoliver added a commit to johnoliver/semantic-kernel that referenced this pull request Jun 5, 2024
Resolves microsoft#1628 

Also setKernelConfig -> withKernelConfig, to be in keeping with other
builder functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Issue or PR regarding Java code
Projects
No open projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

2 participants