.Net Kernel Examples as tests #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto issues/3999-samples-as-tests
RogerBarreto
changed the title
dotnet/samples/KernelSyntaxExamples/Example05_InlineFunctionDefinition.cs
Show resolved
Hide resolved
dotnet/samples/KernelSyntaxExamples/Example01_MethodFunctions.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/KernelSyntaxExamples/Example45_MultiStreamingChatCompletion.cs
Show resolved
Hide resolved
|
I'm not sure this is better way. For example rider is forcing build projects always before run tests session. That is annoying slow down. |
|
But if you prefer examples in the form of tests, I would go one step further and break the tests into smaller ones, i.e. depending on the deployment type (for example openai, azure, google, bing), and instead of checking whether the configuration is not null turn the configuration check into an assert. You could even break the sub-examples into separate tests. |
SergeyMenshykh
approved these changes
Jan 15, 2024
markwallace-microsoft
approved these changes
Jan 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> PR #4526 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Converted examples 52 and 75 to tests Fix samples project files formatting based on common solution resharper settings. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Bryan-Roe
pushed a commit
to Bryan-Roe/semantic-kernel
that referenced
this pull request
Oct 6, 2024
### Motivation and Context Convert Kernel Examples as Integration Tests.
Bryan-Roe
pushed a commit
to Bryan-Roe/semantic-kernel
that referenced
this pull request
Oct 6, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> PR microsoft#4526 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Converted examples 52 and 75 to tests Fix samples project files formatting based on common solution resharper settings. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Convert Kernel Examples as Integration Tests.