Python: Fixes Plan using an empty function in describe and incorrectly setting context variables for next steps.
#4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Plan using an empty function in describe and incorrectly setting context variables for next steps.Plan using an empty function in describe and incorrectly setting context variables for next steps.
eavanvalkenburg
requested changes
Jan 19, 2024
…d-context-variable-resolution
moonbox3
approved these changes
Jan 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
juliomenendez
deleted the
juliome/issue-2933-4658-fix-plan-describe-and-context-variable-resolution
branch
Bryan-Roe
pushed a commit
to Bryan-Roe/semantic-kernel
that referenced
this pull request
Oct 6, 2024
…tly setting context variables for next steps. (microsoft#4673) ### Motivation and Context This PR fixes microsoft#4658 and fixes microsoft#2933. ### Description The first one basically needed a None check before using `self._function` in the `Plan.describe` method. The second one was incorrectly setting the values for variables for the next step in the plan. The solution for this was suggested by @amritpal-singh-98, thank you! ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes #4658 and fixes #2933.
Description
The first one basically needed a None check before using
self._functionin thePlan.describemethod.The second one was incorrectly setting the values for variables for the next step in the plan. The solution for this was suggested by @amritpal-singh-98, thank you!
Contribution Checklist