Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: fix discrimator field for CMC #8417

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Turns out we had a mistake in the way CMC discriminates content types, this PR fixes that

Description

Adds discriminator field to the item in the list rather then the list itself
Adds additional tests

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner August 29, 2024 12:49
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Aug 29, 2024
@markwallace-microsoft
Copy link
Member

Python Test Coverage

Python Test Coverage Report
FileStmtsMissCoverMissing
semantic_kernel
   kernel.py1994776%150, 161, 165, 315–318, 425, 439–482
semantic_kernel/agents/channels
   open_ai_assistant_channel.py49198%42
semantic_kernel/agents/group_chat
   agent_chat.py116199%91
   agent_group_chat.py67297%113, 135
   broadcast_queue.py72199%35
semantic_kernel/agents/open_ai
   assistant_content_generation.py68297%81–82
   open_ai_assistant_base.py361399%243, 321–322
semantic_kernel/connectors/ai/azure_ai_inference/services
   azure_ai_inference_chat_completion.py153497%177, 327–328, 444
semantic_kernel/connectors/ai/embeddings
   embedding_generator_base.py8188%50
semantic_kernel/connectors/ai/google
   shared_utils.py39295%97, 119
semantic_kernel/connectors/ai/google/google_ai/services
   google_ai_chat_completion.py152497%155, 267, 301–302
   utils.py63395%139, 157–162
semantic_kernel/connectors/ai/google/vertex_ai/services
   utils.py65395%141, 159–164
   vertex_ai_chat_completion.py152497%149, 260, 294–295
semantic_kernel/connectors/ai/hugging_face/services
   hf_text_completion.py54394%97, 105, 136
   hf_text_embedding.py32584%79–83
semantic_kernel/connectors/memory/azure_ai_search
   azure_ai_search_collection.py87298%150, 152
semantic_kernel/connectors/memory/redis
   redis_collection.py160299%146, 316
   utils.py451176%145–146, 164, 166, 173–188
semantic_kernel/connectors/openapi_plugin
   openapi_manager.py58297%110–111
   openapi_parser.py88199%127
   openapi_runner.py105298%181–182
semantic_kernel/connectors/openapi_plugin/models
   rest_api_operation.py129199%242
semantic_kernel/contents
   function_call_content.py97199%201
semantic_kernel/data
   vector_store_record_collection.py2491992%410, 470–474, 482–486, 526–529, 536–539
   vector_store_record_utils.py26292%50, 52
semantic_kernel/functions
   kernel_function_decorator.py98199%102
   kernel_function_from_method.py96199%153
   kernel_function_from_prompt.py154795%165–166, 180, 201, 219, 239, 322
   kernel_function_log_messages.py36683%37–43
   kernel_plugin.py187299%472, 475
semantic_kernel/planners
   plan.py2344581%54, 163–165, 197, 214–227, 264, 269, 277–278, 288–291, 308, 313, 329, 332–337, 355, 360, 363, 365, 372, 386–388, 393–397
semantic_kernel/planners/function_calling_stepwise_planner
   function_calling_stepwise_planner.py116497%145, 189–190, 198
semantic_kernel/planners/sequential_planner
   sequential_planner.py64691%71, 75, 109, 125, 134–135
   sequential_planner_extensions.py50982%31–32, 56, 110–124
   sequential_planner_parser.py771284%66–74, 93, 117–120
semantic_kernel/schema
   kernel_json_schema_builder.py119596%50, 84, 206, 210–211
semantic_kernel/template_engine/blocks
   code_block.py77199%119
   named_arg_block.py43198%98
semantic_kernel/utils/telemetry
   user_agent.py16288%18–19
semantic_kernel/utils/telemetry/model_diagnostics
   decorators.py105298%206, 210
TOTAL1082523398% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
2386 1 💤 0 ❌ 0 🔥 54.540s ⏱️

@TaoChenOSU TaoChenOSU added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Aug 29, 2024
Merged via the queue into microsoft:main with commit 3bfee7b Aug 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants