-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Agents - Streaming Bug Fix and Support Additional Assistant Option #8852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
added
bug
Something isn't working
PR: ready for review
All feedback addressed, ready for reviews
.NET
Issue or Pull requests regarding .NET code
experimental
Associated with an experimental feature
enhancement
agents
labels
Sep 17, 2024
crickman
had a problem deploying
to
integration
September 17, 2024 15:59
— with
GitHub Actions
Error
crickman
had a problem deploying
to
integration
September 17, 2024 16:01
— with
GitHub Actions
Error
crickman
temporarily deployed
to
integration
September 17, 2024 16:03
— with
GitHub Actions
Inactive
crickman
temporarily deployed
to
integration
September 17, 2024 16:12
— with
GitHub Actions
Inactive
dmytrostruk
approved these changes
Sep 17, 2024
moonbox3
approved these changes
Sep 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 17, 2024
crickman
temporarily deployed
to
integration
September 17, 2024 18:03
— with
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 17, 2024
…ithub.com/microsoft/semantic-kernel into fix_agent_streaming_and_assistant_options
markwallace-microsoft
added
the
kernel
Issues or pull requests impacting the core kernel
label
Sep 17, 2024
crickman
had a problem deploying
to
integration
September 17, 2024 19:18
— with
GitHub Actions
Error
dmytrostruk
approved these changes
Sep 17, 2024
crickman
temporarily deployed
to
integration
September 17, 2024 19:20
— with
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 17, 2024
crickman
had a problem deploying
to
integration
September 17, 2024 20:00
— with
GitHub Actions
Error
dmytrostruk
approved these changes
Sep 17, 2024
crickman
temporarily deployed
to
integration
September 17, 2024 20:02
— with
GitHub Actions
Inactive
crickman
removed
the
PR: ready for review
All feedback addressed, ready for reviews
label
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agents
bug
Something isn't working
enhancement
experimental
Associated with an experimental feature
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Respond to two customer identified issues:
Add support for
AdditionalInstructions
for creating an assistant as well as invocation override.Fixes .Net: New Feature: Support additional properties available in
RunCreationOptions
viaOpenAIAssistantInvocationOptions
#8715Fix issue with duplicated tool-call result when using
ChatCompletionAgent
streamingFixes Bug: Agent streaming duplicates message when IAutoFunctionInvocationFilter uses Terminate #8825
Description
AdditionalInstructions
option wasn't included in the V2 migration as oversight. This is a pure addition.AdditionalInstructions
option.ChatCompletionAgent
IAutoFunctionInvocationFilter
:Concepts/Agents/ChatCompletion_FunctionTermination
Contribution Checklist