-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Agents - Align with expectations when arguments override specified. #9096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
added
PR: ready for review
All feedback addressed, ready for reviews
.NET
Issue or Pull requests regarding .NET code
agents
labels
Oct 4, 2024
moonbox3
approved these changes
Oct 4, 2024
crickman
commented
Oct 4, 2024
alliscode
approved these changes
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agents
.NET
Issue or Pull requests regarding .NET code
PR: ready for review
All feedback addressed, ready for reviews
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When default
KernelArguments
are specified forKernelAgent.Arguments
, it is likely expected that when overridearguments
parameter is provided that this override doesn't necessarily invalidate the defaultKernelArguments.ExecutionSettings
.Description
Provide performant merge logic for default and override
KernelArguments
for all invocations.This merge preserves any default values not specifically included in the override...including both
ExecutionSettings
and parameters.Solves this (common) pattern:
Contribution Checklist