Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Broken links across the repository #2000

Closed
gauravkeshre opened this issue Sep 10, 2024 · 1 comment · Fixed by #2073
Closed

[Bug]: Broken links across the repository #2000

gauravkeshre opened this issue Sep 10, 2024 · 1 comment · Fixed by #2073
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@gauravkeshre
Copy link
Member

gauravkeshre commented Sep 10, 2024

Language

Javascript/Typescript, C#, Python

Version

latest

Description

I ran a broken link check on the repo and found that there are over 50 broken links some of which return HTTP error 404, 403.
Attaching the report file with this issue.
teams-ai-broken-links.txt

Reproduction Steps

  1. install link checker npm install -g markdown-link-check
  2. cd into teams-ai
  3. run for file in $(find . -type f -name '*.md'); do markdown-link-check "$file"; done
  4. Observe the results (attaching a simplified report)
@corinagum
Copy link
Collaborator

corinagum commented Sep 13, 2024

I did not know about this package, and I love it! Thank you for the heads up! Re-reviewing your PR -- it looks like the ones you addressed were handled?

FYI, some of the links we post are internal-only, which I understand can be frustrating and counter-intuitive in an open-source repo. Those links will very likely remain in our readme's.

@corinagum corinagum self-assigned this Sep 13, 2024
@corinagum corinagum added documentation Improvements or additions to documentation and removed bug Something isn't working labels Sep 13, 2024
@corinagum corinagum assigned SubbaReddi and unassigned corinagum Sep 25, 2024
corinagum pushed a commit that referenced this issue Sep 25, 2024
## Linked issues

closes: #minor

## Details

Provide a list of your changes here. If you are fixing a bug, please
provide steps to reproduce the bug.
Reference: #2000

#### Change details

> Describe your changes, with screenshots and code snippets as
appropriate
Link to Azure OpenAI On Your Data is corrected

## Attestation Checklist

- [x] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below
corinagum added a commit that referenced this issue Sep 25, 2024
## Linked issues

closes: #minor

## Details

Provide a list of your changes here. If you are fixing a bug, please
provide steps to reproduce the bug.
Reference: #2000
#### Change details

> Describe your changes, with screenshots and code snippets as
appropriate
Link to "other-ways-to-run-the-sample" is corrected


## Attestation Checklist

- [ ] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
corinagum added a commit that referenced this issue Sep 25, 2024
## Linked issues

closes: #minor

## Details

Provide a list of your changes here. If you are fixing a bug, please
provide steps to reproduce the bug.
Reference: #2000
#### Change details

> Describe your changes, with screenshots and code snippets as
appropriate
Link to "other-ways-to-run-the-sample" is corrected


## Attestation Checklist

- [ ] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants