[JS] chore: dependencies cleanup: typescript, teamsfx, and browserify #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
aacebo,
lilyydu and
singhk97
as code owners
aacebo
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #1947
closes #1371
TLDR: Node 20 is now supported!!! If you're eager for this, you shouldn't need to wait for a release, as the affected packages were our samples.
Details
typescriptto only allow patch updates. See Change details below for more information. This is (ideally) temporary.@microsoft/teamsfxas a dependency - it turns out this dependency is entirely unused, but due to sub-dependencies was preventing us from being able to support Node >=18. Because of this andbotbuilder-js@4.23.xnow supporting node 20, teams-ai js package now also runs with node 20 too!browserify- unused dependencyplanner.Change details
TS made an update that in 5.6 reveals previously 'hidden' TS errors.
gpt-tokenizerandbotbuilderhave TS errors that 5.6 catches. I filed bugs for both packages:[Bug] Cannot upgrade to TS 5.6x due to build errors · Issue #49 · niieani/gpt-tokenizer (github.com)
Cannot bump typescript to 5.6 due to botbuilder
INodeBuffererror · Issue #4746 · microsoft/botbuilder-js (github.com)Attestation Checklist
My code follows the style guidelines of this project
I have checked for/fixed spelling, linting, and other errors
I have commented my code for clarity
I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)
My changes generate no new warnings
I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:
New and existing unit tests pass locally with my changes
Additional information