Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] fix: missing sendActivity invoke for file consent accept/decline handlers #2017

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

lilyydu
Copy link
Contributor

@lilyydu lilyydu commented Sep 13, 2024

Linked issues

closes: #2004

Details

  • for JS/PY, the handle wrappers were missing the sendActivity call, resulting in 502s and automatic retries
  • linting

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

@corinagum corinagum merged commit eb5a9fa into main Sep 13, 2024
19 checks passed
@corinagum corinagum deleted the lilyydu/file-consent branch September 13, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File Consent Leads to NotImplemented Error and Automatic Retries
2 participants