Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] fix: CardGazer sample #2059

Merged
merged 3 commits into from
Sep 26, 2024
Merged

[JS] fix: CardGazer sample #2059

merged 3 commits into from
Sep 26, 2024

Conversation

corinagum
Copy link
Collaborator

@corinagum corinagum commented Sep 25, 2024

Linked issues

#2039
#minor

image

Details

  • OpenAIModel.ts docstring cleanup
  • PromptManager - change order of tools and user input
  • UserInputMessage - don't send messages if messages are empty.
  • Update cardgazer to use 4o-mini and tools augmentation
  • Update CardGazer sample to improve experience.
  • Add note in README for Bot SSO sample

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@corinagum corinagum merged commit 1e61623 into main Sep 26, 2024
18 of 19 checks passed
@corinagum corinagum deleted the cg/cardGazer-4o branch September 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants