Turn State Infrastructure #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vule-msft
approved these changes
Jul 11, 2023
...ages/Microsoft.Bot.Builder.M365/Microsoft.Bot.Builder.M365/AI/Planner/ConversationHistory.cs
Outdated
Show resolved
Hide resolved
swatDong
reviewed
Jul 11, 2023
dotnet/packages/Microsoft.Bot.Builder.M365/Microsoft.Bot.Builder.M365/State/TurnStateManager.cs
Outdated
Show resolved
Hide resolved
swatDong
approved these changes
Jul 11, 2023
kuojianlu
reviewed
Jul 11, 2023
...ckages/Microsoft.Bot.Builder.M365/Microsoft.Bot.Builder.M365/AI/Moderator/OpenAIModerator.cs
Outdated
Show resolved
Hide resolved
kuojianlu
reviewed
Jul 11, 2023
...ot.Builder.M365/Microsoft.Bot.Builder.M365/AI/AzureContentSafety/AzureContentSafetyClient.cs
Outdated
Show resolved
Hide resolved
swatDong
approved these changes
Jul 11, 2023
kuojianlu
approved these changes
Jul 11, 2023
swatDong
added a commit
that referenced
this pull request
Jul 12, 2023
Refactor action handling system to support dynamic action import with necessary parameters, resolves #212 - Action method can use parameter attributes `ActionTurnContext`, `ActionTurnState`, `ActionEntities`, `ActionName` to get inputs. - Support `void` / `bool` / `Task` / `Task<bool>` / `ValueTask` / `ValueTask<bool>` return types. - Have runtime type checker. For example, ``` csharp [Action("action1")] public void MyAction( [ActionTurnContext] ITurnContext context, [ActionTurnState] TState state, [ActionEntities] MyDataType entities, [ActionName] string actionName) { ... } ``` This PR may have conflict with the turn state one. I'll merge and resolve conflicts after #232 merged. For code analyzer, created #237 to track to not block the action system itself or sample work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the turn state. resolves #209
Additions
Missing that will come in subsequent PRs:
Applicationunit testsAIclass unit testsA few major differences between this and the JS SDK:
DefaultfromDefaultTurnStateto getTurnState. Not sure whyDefaultwas there in the first place, I presume it's to signal to the user that this component is configurable. We do that implictly in C# with interfaces (ex.ITurnStateManager) and unsealed class (ex.TurnState).Applicationclass now has two generic parameters,TStateandTTurnStateManager. This was to solve the problem that there is virtually no covariance in C# generic types (i.eITurnStateManager<TurnState> var = TurnStateManager<ChildTurnState>throws compiler errors, even thoughChildTurnStateextendsTurnState).