Skip to content

Commit

Permalink
Fix tab selection to bring the tab into view (#8832)
Browse files Browse the repository at this point in the history
## PR Checklist
* [x] Closes #3638
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [x] I've discussed this with core contributors already.

##Detailed Description of the Pull Request / Additional comments
A workaround for microsoft/microsoft-ui-xaml#3945.
Thanks to @michael-hawker and @chingucoding for the suggested solution.
  • Loading branch information
Don-Vito authored Jan 20, 2021
1 parent f196285 commit 12b12d5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/cascadia/TerminalApp/TerminalPage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2208,6 +2208,8 @@ namespace winrt::TerminalApp::implementation
_UpdateMRUTab(index);
}

tab.TabViewItem().StartBringIntoView();

// Raise an event that our title changed
_titleChangeHandlers(*this, tab.Title());
}
Expand Down

0 comments on commit 12b12d5

Please sign in to comment.