WriteCharsLegacy: Accumulated bugs

[DHowett]

Inserting a tab character that would put us at the right edge of the buffer inserts two tabs (one to get us to the right edge of the buffer, one more after we wrap)

Code and example

#include <windows.h>
int main() {
        CONSOLE_SCREEN_BUFFER_INFOEX csbiex{};
        csbiex.cbSize = sizeof(csbiex);
        GetConsoleScreenBufferInfoEx(GetStdHandle(STD_OUTPUT_HANDLE), &csbiex);
        SetConsoleCursorPosition(GetStdHandle(STD_OUTPUT_HANDLE), COORD{(SHORT)(csbiex.dwSize.X - 9), csbiex.dwCursorPosition.Y});
        WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), L"|\t|\n", 4, nullptr, nullptr);
        return 0;
}

Inserting a printable control character at the right edge of the screen (ala ^A) when only the ^ would fit emits a ^ and a space.

Example

(here, ^D)

Inserting a printable control character (^D) at the right edge of the screen when both ^ and D fit and then backspacing it deletes the ^, not the D:

Example

[DHowett]

Tab bug: the measurer "eats" the space before it decides that the Tab does not fit. The bulk text inserter then uses the estimated position (which was consumed by the tab we aborted inserting) to move the cursor. Then when WCL loops back around to insert the tab on the next line it measures back out at 8 characters and inserts it again.

[DHowett]

Control char bug 1: WCL does not consider a printable control char to take up 2 spaces when it is trying to fit it up against the edge of the screen. Correct behavior: treat ^D as two characters and push the whole sequence down to the next line, or print ^ and D on separate lines and be sure to delete them both.