Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.12: I'm betting there's weirdness with vintage opacity and cleartype #11315

Closed
zadjii-msft opened this issue Sep 23, 2021 · 1 comment · Fixed by #11368
Closed

1.12: I'm betting there's weirdness with vintage opacity and cleartype #11315

zadjii-msft opened this issue Sep 23, 2021 · 1 comment · Fixed by #11368
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.12

Comments

@zadjii-msft
Copy link
Member

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 23, 2021
@zadjii-msft
Copy link
Member Author

snippet of the settings that caused this:

    "profiles": 
    {
        "defaults": 
        {
            "antialiasingMode": "cleartype",
            // "bellStyle": "window",
            "experimental.retroTerminalEffect": false
        },
        "list": 
        [
            {
                "background": "#012456",
                "closeOnExit": "graceful",
                "colorScheme": "Campbell Powershell",
                "commandline": "powershell.exe",
                "cursorColor": "#FFFFFF",
                "cursorShape": "bar",
                "font": 
                {
                    "face": "Code New Roman",
                    "size": 10
                },
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "historySize": 9001,
                "name": "Powershell",
                "opacity": 50,
                "padding": "0, 0, 0, 0",
                "snapOnInput": true,
                "startingDirectory": "C:/Windows",
                "useAcrylic": false
            },

It did go away on a settings reload, so maybe there's hope. Probably just didn't init the background correctly in DX for the "transparent, not acrylic" case

@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Sep 23, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 23, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.12 milestone Sep 23, 2021
zadjii-msft added a commit that referenced this issue Sep 29, 2021
@zadjii-msft
Always init the BG opacity with the renderer
76e3477 
  Missed this in #11180. I forgot to init the BG opacity with the renderer on startup, because that matters when you have `"antialiasingMode": "cleartype",`.

  Repro json
  ```json
    {
        "commandline": "cmd.exe",
        "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
        "hidden": false,
        "opacity": 35,
        "antialiasingMode": "cleartype",
        "padding": "0",
        "name": "Command Prompt"
    },
  ```

  * [x] Fixes #11315
@zadjii-msft zadjii-msft mentioned this issue Sep 29, 2021
Merged
1 task
@ghost ghost added the In-PR This issue has a related PR label Sep 29, 2021
@ghost ghost closed this as completed in #11368 Sep 29, 2021
ghost pushed a commit that referenced this issue Sep 29, 2021
@zadjii-msft
Always init the BG opacity with the renderer (#11368)
d25ca26 
Missed this in #11180. I forgot to init the BG opacity with the renderer on startup, because that matters when you have `"antialiasingMode": "cleartype",`.

Repro json
```json
{
    "commandline": "cmd.exe",
    "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
    "hidden": false,
    "opacity": 35,
    "antialiasingMode": "cleartype",
    "padding": "0",
    "name": "Command Prompt"
},
```

* [x] Fixes #11315
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 29, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging a pull request may close this issue.

Always init the BG opacity with the renderer microsoft/terminal
1 participant
@zadjii-msft