Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal can't be indexed by powertoys #12406

Closed
c2ray opened this issue Feb 7, 2022 · 5 comments · Fixed by #12491
Closed

Terminal can't be indexed by powertoys #12406

c2ray opened this issue Feb 7, 2022 · 5 comments · Fixed by #12491
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@c2ray
Copy link

c2ray commented Feb 7, 2022 •
edited
Loading

Windows Terminal version

1.12.10334.0

Windows build number

10.0.19043.0

Other Software

No response

Steps to reproduce

press alt + space.
enter terminal

Expected Behavior

I can see Terminal in the list as early release.

Actual Behavior

I can't see Terminal in the list.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 7, 2022
@DHowett
Copy link
Member

DHowett commented Feb 7, 2022

This is a /duplicate of microsoft/PowerToys#16118

@ghost
Copy link

ghost commented Feb 7, 2022

Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!

@ghost ghost closed this as completed Feb 7, 2022
@ghost ghost added Resolution-External For issues that are outside this codebase and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 7, 2022
@DHowett
Copy link
Member

DHowett commented Feb 7, 2022 •
edited
Loading

(Thanks for the report!)

@DHowett DHowett mentioned this issue Feb 14, 2022
Merged
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 15, 2022
ghost pushed a commit that referenced this issue Feb 15, 2022
@DHowett
Copy localized strings from ContextMenu into the resource root (#12491)
9501b23 
We chose to use the "ContextMenu" resource compartment when we
changed the package name to Terminal in #12264 because it was more
broadly localized than the rest of the application.

It appears as though some platform features have trouble with the
"more qualified" resource paths that #12264 required.

To fix this, we will:

1. Copy all of the ContextMenu localizations into CascadiaPackage's
   resource root
2. Switch all manifest resource paths to use resources from the package
   root.

Regressed in #12264
Closes #12384
Closes #12406 (tracked in microsoft/PowerToys#16118)
DHowett added a commit that referenced this issue Feb 16, 2022
@DHowett
Copy localized strings from ContextMenu into the resource root (#12491)
20a1048 
We chose to use the "ContextMenu" resource compartment when we
changed the package name to Terminal in #12264 because it was more
broadly localized than the rest of the application.

It appears as though some platform features have trouble with the
"more qualified" resource paths that #12264 required.

To fix this, we will:

1. Copy all of the ContextMenu localizations into CascadiaPackage's
   resource root
2. Switch all manifest resource paths to use resources from the package
   root.

Regressed in #12264
Closes #12384
Closes #12406 (tracked in microsoft/PowerToys#16118)

(cherry picked from commit 9501b23)
DHowett added a commit that referenced this issue Feb 16, 2022
@DHowett
Copy localized strings from ContextMenu into the resource root (#12491)
e6010b8 
We chose to use the "ContextMenu" resource compartment when we
changed the package name to Terminal in #12264 because it was more
broadly localized than the rest of the application.

It appears as though some platform features have trouble with the
"more qualified" resource paths that #12264 required.

To fix this, we will:

1. Copy all of the ContextMenu localizations into CascadiaPackage's
   resource root
2. Switch all manifest resource paths to use resources from the package
   root.

Regressed in #12264
Closes #12384
Closes #12406 (tracked in microsoft/PowerToys#16118)

(cherry picked from commit 9501b23)
@ghost
Copy link

ghost commented Mar 25, 2022

🎉This issue was addressed in #12491, which has now been successfully released as Windows Terminal v1.12.1073.:tada:

Handy links:

@ghost
Copy link

ghost commented Mar 25, 2022

🎉This issue was addressed in #12491, which has now been successfully released as Windows Terminal Preview v1.13.1073.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copy localized strings from ContextMenu into the resource root microsoft/terminal
2 participants
@DHowett @c2ray