[1.14] ShowWindow(SW_MINIMIZE) doesn't work anymore

[zadjii-msft]

From bug bash.

1. put in file:

$Source=@"
using System;
using System.Runtime.InteropServices;
public class Native {
[DllImport("user32.dll")]
public static extern bool ShowWindow(IntPtr hWnd, int nCmdShow);
[DllImport("kernel32.dll", SetLastError = true)]
public static extern IntPtr GetConsoleWindow();
}
"@
Add-Type -TypeDefinition $Source
[Native]::ShowWindow([Native]::GetConsoleWindow(), 6)

2. Run .\hide.ps1

expect:

• See a dterm sequence for hiding the window

actual:

• Terminal still visible.

[zadjii-msft]

I was the murderer

69b77ca

That's a 1 line fix, but fixing that causes the window to flicker uncontrollably. Somewhere there's a mismatch between the Terminal HWND visibility and the ConPTY one, some flipped boolean somewhere.

[zadjii-msft]

• ✔️ 22fb15f - definitely works, no flashing.
• ❔ 90d6fe7
• ❔ 419551e
• ❔ 5b59cf8
• ✔️ 6bdc8c9
• ⚠️ 69b77ca - the bad merge. Presumably, anything after here doesn't work, but maybe with the merge fixed they would?
  • Even with the fix to the merge, this causes the flashing. Everything after here would as well.
  • This was a merge with 26d67d9, which was Enable the Terminal to tell ConPTY who the owner is #12526.
  • ✔️ 479c6c9 was my branch where I thought I merged these all and it worked. That's basically a merge of (5923cf3, 23b6fee, and 5923cf3, the last of which was NOT the whole focus/foreground implementation, merely a prototype. Shiz. )
    • This commit DOES work. So somewhere between there and 69b77ca broke. Interesting.
• ❔ d54e6d1
• ❔ 9aa987f
• ❔ f70c53d
• ❔ 46b88e1
• ❌ 3b9710a - didn't work, but neither does the test script so clearly I never tested that build. That's after the bad merge, so yea that doesn't work,
• ❌ main

[zadjii-msft]

Hmm. It's the combo of 22fb15f with #12526 that causes this. That initial show/hide to sync the terminal with the conpty, that's what's busted somehow.

Merely commenting those lines fixes this. (see bbae235) HOWEVER, it breaks doing a [Native]::ShowWindow([Native]::GetConsoleWindow(), 0) (0==SW_HIDE) immediately in a fresh window. Trick here: the Terminal starts with WS_VISIBLE | !WS_MINIMIZE. The Conpty starts with !WS_VISIBLE | !WS_MINIMIZE. Somewhere early in startup, we get a WM_SHOWWINDOW(false, 0), and that then bounces with the terminal, because that results in the pty telling the terminal to hide.

• ❔ I need to validate that [Native]::ShowWindow([Native]::GetConsoleWindow(), 0) did work between 2fb15f and 69b77ca
• ✔️ Does removing the ConptyReparentPseudoConsole call instead fix this? Is the window getting hidden as a result of being reparented? I've determined that the window is 100% of the time created by ::ConsoleInputThreadProcWin32 in windowio.cpp, and that creates it without the owner hwnd.
  • It did, but the plot thickens.

[zadjii-msft]

The plot thickens. Remove the call to reparent, but leave the initial state sync in. Things seem to work. HOWEVER, if you minimize the Terminal, then restore it, the terminal doesn't get focus. I bet that the pty window is becoming WS_VISIBLE, which means it's now a valid target to become the foreground window, even though its dimensions are 0x0 and not drawn anywhere. Interesting.

• ❌ try WS_EX_NOACTIVATE
• try the cloaking thing again.

lmao

However, you can display the system menu by right-clicking or by typing ALT+SPACE.

Yep you can sure do that.

[zadjii-msft]

This doesn't work with DefTerm until the window is minimized and restored once. :|