Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll marks missing from JSON schema #13404

Closed
cinnamon-msft opened this issue Jun 30, 2022 · 1 comment · Fixed by #13414
Closed

Scroll marks missing from JSON schema #13404

cinnamon-msft opened this issue Jun 30, 2022 · 1 comment · Fixed by #13414
Labels
Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.15

Comments

@cinnamon-msft
Copy link
Contributor

The scroll marks settings and actions are missing from the JSON schema.

Settings/actions added here: #12948
@cinnamon-msft cinnamon-msft added Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. Area-Schema Things that have to do with the json schema. labels Jun 30, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 30, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.15 milestone Jul 1, 2022
@PankajBhojwani PankajBhojwani mentioned this issue Jul 1, 2022
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 1, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 1, 2022
carlos-zamora pushed a commit that referenced this issue Jul 1, 2022
@PankajBhojwani
Update schema with scroll marks actions and settings (#13414)
478c2c3 
Update schema with the settings/actions added in #12948 

## PR Checklist
* [x] Closes #13404
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Schema updated.
DHowett pushed a commit that referenced this issue Jul 5, 2022
@PankajBhojwani @DHowett
Update schema with scroll marks actions and settings (#13414)
2fdcd4e 
Update schema with the settings/actions added in #12948

## PR Checklist
* [x] Closes #13404
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Schema updated.

(cherry picked from commit 478c2c3)
Service-Card-Id: 83790285
Service-Version: 1.15
@ghost
Copy link

ghost commented Jul 6, 2022

🎉This issue was addressed in #13414, which has now been successfully released as Windows Terminal Preview v1.15.186.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.15
Development

Successfully merging a pull request may close this issue.

Update schema with scroll marks actions and settings microsoft/terminal
2 participants
@carlos-zamora @cinnamon-msft